This repository has been archived by the owner on May 25, 2021. It is now read-only.
Add counters for lifetime total queued and dequeued items #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ | |||
| -include_lib("couch/include/couch_db.hrl"). | |||
|
|
|||
| % public API | |||
| -export([new/1, queue/2, dequeue/1, dequeue/2, close/1, item_count/1, size/1]). | |||
| -export([new/1, queue/2, queue/3, dequeue/1, dequeue/2, close/1, item_count/1, size/1, total_in/1, total_out/1, total_held/1]). | |||
There was a problem hiding this comment.
May be wrap this to fit 80 (at least) line right margin?
|
Here need some tests to make sure that it counts right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables a work queue to keep a running total of all the work that's ever been added to it, queryable through the functions
total_in/1,total_out/1, andtotal_held/1. Additionally, aqueue(Wq, Item, CountsAs)function-clause has been added and exported, which enables a single queue-item to be counted as an arbitrary number of work-items from the perspective of the running total counters. This allows for the ability to track the total number of individual work-items processed, even when queuing and dequeuing are done in "chunks" of items, as is done incouch_index_updater.COUCHDB-2955
BugzID: 14036