feat(browser): Work on browser (CB-12024) #67
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@asfgit What can I do to accelerate the process of getting this accepted? |
There was a problem hiding this comment.
Thanks for the PR! A couple of things:
- can you rebase w/ the latest master?
- I feel like the entry line in the docs should change from "The
StatusBarobject provides some functions to customize the iOS and Android StatusBar." to clarify that (some) browsers are also supported. - can you provide me some guidance on how i can test this out on a browser platform? What browser would support this?
README.md
Outdated
| @@ -73,6 +73,9 @@ if (cordova.platformId == 'android') { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Browser Support | |||
There was a problem hiding this comment.
May I suggest renaming this heading to "Browser Quirks", to align with the other section headings (i.e. "Android Quirks").
README.md
Outdated
| @@ -73,6 +73,9 @@ if (cordova.platformId == 'android') { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Browser Support | |||
| Only a limited selection of browsers offer support for setting status bar colors. | |||
There was a problem hiding this comment.
Can you expand on which browsers offer this support? I feel like that's valuable information for this documentation.
…gin-statusbar # Conflicts: # README.md
|
@filmaj I've rebased with master and made the requested changes to the README. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
README.md
Outdated
| @@ -30,7 +30,7 @@ description: Control the device status bar. | |||
| StatusBar | |||
| ====== | |||
|
|
|||
| > The `StatusBar` object provides some functions to customize the iOS and Android StatusBar. | |||
| > The `StatusBar` object provides some functions to customize the iOS and Android StatusBar, as well as some browser chrome. | |||
There was a problem hiding this comment.
What does "some browser chrome" exactly mean here?
"browser window on some (mobile OS system) browsers"?
There was a problem hiding this comment.
It varies by browser support of course, but it typically means the tab color and the navigation bar color.
There was a problem hiding this comment.
I can extend the explanation of the affected browser chrome, but I think that is better handled by the caniuse page.
|
Looking pretty good @dudeofawesome. I left a question, could you also maybe again rebase on master to get rid of the README conflict? Also, what are the easiest steps to try this out? |
|
@janpio Rebased! To try it out, I'd pretty much just set up a regular demo project for the statusbar plugin, but add the browser platform and run it. It should just work. |
|
Thanks. I installed the plugin from your PR branch and adapted the default project: But I couldn't get it to work on iOS, both directly in Safari and also after adding the page to the homescreen and opening from there - nothing happened. I published the browser www here: Did I miss anything @dudeofawesome ? Can someone test on iOS and Windows Phone? |
|
@dudeofawesome Could you have a look at my questions, I couldn't get this to work. Otherwise we would have to treat this PR as abandoned, which would be a shame. |
janpio
changed the title
The StatusBar plugin can support the Browser platform at least on Chrome for Android, and potentially on other browsers as well.