Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) Don't overwrite the whole SystemUiVisibility in setStatusBarTransparent #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohammadrafigh
Copy link

Fixes #275

Platforms affected

Android

Motivation and Context

in setStatusBarTransparent function, current SystemUiVisibility is being replaced by the new one, which is incorrect as stated in #275.

Description

Like other places in the same codebase, I just called getSystemUiVisibility before applying the new flags and used current visibility as a base option for those flags.

Testing

It's already mentioned in #275.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin overwrites windowLightNavigationBar theme settings
1 participant