CB-13123 : plugin add should use cordovaDependency instead #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreyso
force-pushed
the
CB-13123
branch
3 times, most recently
from
314a6e9 to
d747dc9
Compare
…f plugin.xml engine tag
|
This is not going to make next release, getting bumped for now |
|
Next to failing tests this PR now also has conflicts. Could you please rebase on master @audreyso and fix those? Then we can take another look at those test failures. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of plugin.xml engine tag
Platforms affected
What does this PR do?
plugin add/ install should use cordovaDependency instead of plugin.xml engine tag
What testing has been done on this change?
Checklist