Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Issue and Pull Request templates #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented May 24, 2019

Platforms affected

Motivation and Context

Update GitHub Issues and Pull Request templates.

Description

  • Improve wording
  • Fix grammar mistakes
  • Update Pull Request checklist
  • Remove unnecessary details

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         569    569           
=====================================
  Hits          569    569

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf4945...c915ee2. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         569    569           
=====================================
  Hits          569    569

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf4945...c915ee2. Read the comment docs.

@GedasGa GedasGa changed the title Update GitHub Issues and Pull Request templates Update GitHub Issue and Pull Request templates May 24, 2019
@GedasGa
Copy link
Contributor Author

GedasGa commented May 24, 2019

@janpio

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Apache Cordova has standardized GitHub templates for all repositories: https://github.com/apache/cordova-contribute/blob/master/github-templates.md So best please open a PR over there with the same changes so we can discuss the details. Most of this is good, some of it maybe not, some should probably be discussed a bit further.

@GedasGa
Copy link
Contributor Author

GedasGa commented May 24, 2019

Ok, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants