-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add backwards compatibility mode for WebViewAssetLoader #1222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 21 21
Lines 1695 1695
=======================================
Hits 1220 1220
Misses 475 475 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works fine, thanks!
Platforms affected
Android
Motivation and Context
As we discussed on the list we might need a fallback for the new changes in #1137
With this PR you can fall back to using files instead of https://localhost with this preference:
<preference name="AndroidInsecureFileModeEnabled" value="true" />
Documentation: apache/cordova-docs#1172
Testing
Manual
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)