Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-414] Don't write a BOM on every (or any) line #492

Merged
merged 6 commits into from
Oct 7, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 7, 2023

Per JDK docs, "When decoding, the UTF-16 charset interprets the byte-order mark at the beginning of the input stream to indicate the byte-order of the stream but defaults to big-endian if there is no byte-order mark; when encoding, it uses big-endian byte order and writes a big-endian byte-order mark."

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Merging #492 (25c4e69) into master (877b9e3) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     84.97%   85.07%   +0.10%     
- Complexity     3372     3373       +1     
============================================
  Files           227      227              
  Lines          8080     8082       +2     
  Branches        953      954       +1     
============================================
+ Hits           6866     6876      +10     
+ Misses          960      951       -9     
- Partials        254      255       +1     
Files Coverage Δ
src/main/java/org/apache/commons/io/IOUtils.java 86.81% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garydgregory garydgregory merged commit 469ef76 into apache:master Oct 7, 2023
12 checks passed
@garydgregory garydgregory changed the title [IO-414] don't write a BOM on every (or any) line [IO-414] Don't write a BOM on every (or any) line Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
elharo added a commit to elharo/commons-io that referenced this pull request Oct 8, 2023
elharo added a commit to elharo/commons-io that referenced this pull request Oct 8, 2023
garydgregory pushed a commit that referenced this pull request Oct 8, 2023
* Revert "Revert "[IO-414] don't write a BOM on every (or any) line (#492)""

This reverts commit 43594ce.

* Revert "Revert "[IO-414] Don't write a BOM on every (or any) line #492""

This reverts commit 914ca79.

* revert the revert

* detab

* detab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants