Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS) #4304

Merged

Commits on Feb 18, 2021

  1. Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

    This enables support for PowerFlex/ScaleIO (v3.5 onwards) storage pool as a primary storage in CloudStack
    
    Other improvements addressed in addition to PowerFlex/ScaleIO support:
    
    - Added support for config drives in host cache for KVM
    	=> Changed configuration "vm.configdrive.primarypool.enabled" scope from Global to Zone level
    	=> Introduced new zone level configuration "vm.configdrive.force.host.cache.use" (default: false) to force host cache for config drives
    	=> Introduced new zone level configuration "vm.configdrive.use.host.cache.on.unsupported.pool" (default: true) to use host cache for config drives when storage pool doesn't support config drive
    	=> Added new parameter "host.cache.location" (default: /var/cache/cloud) in KVM agent.properties for specifying the host cache path and create config drives on the "/config" directory on the host cache path
    	=> Maintain the config drive location and use it when required on any config drive operation (migrate, delete)
    
    - Detect virtual size from the template URL while registering direct download qcow2 (of KVM hypervisor) templates
    
    - Updated full deployment destination for preparing the network(s) on VM start
    
    - Propagate the direct download certificates uploaded to the newly added KVM hosts
    
    - Discover the template size for direct download templates using any available host from the zones specified on template registration
    	=> When zones are not specified while registering template, template size discovery is performed using any available host, which is picked up randomly from one of the available zones
    
    - Release the VM resources when VM is sync-ed to Stopped state on PowerReportMissing (after graceful period)
    
    - Retry VM deployment/start when the host cannot grant access to volume/template
    
    - Mark never-used or downloaded templates as Destroyed on deletion, without sending any DeleteCommand
    	=> Do not trigger any DeleteCommand for never-used or downloaded templates as these doesn't exist and cannot be deleted from the datastore
    
    - Check the router filesystem is writable or not, before performing health checks
    	=> Introduce a new test "filesystem.writable.test" to check the filesystem is writable or not
    	=> The router health checks keeps the config info at "/var/cache/cloud" and updates the monitor results at "/root" for health checks, both are different partitions. So, test at both the locations.
    	=> Added new script: "filesystem_writable_check.py" at /opt/cloud/bin/ to check the filesystem is writable or not
    
    - Fixed NPE issue, template is null for DATA disks. Copy template to target storage for ROOT disk (with template id), skip DATA disk(s)
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    11c81b0 View commit details
    Browse the repository at this point in the history
  2. Addressed some issues for few operations on PowerFlex storage pool.

    - Updated migration volume operation to sync the status and wait for migration to complete.
    
    - Updated VM Snapshot naming, for uniqueness in ScaleIO volume name when more than one volume exists in the VM.
    
    - Added sync lock while spooling managed storage template before volume creation from the template (non-direct download).
    
    - Updated resize volume error message string.
    
    - Blocked the below operations on PowerFlex storage pool:
      -> Extract Volume
      -> Create Snapshot for VMSnapshot
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    6085c06 View commit details
    Browse the repository at this point in the history
  3. Added the PowerFlex/ScaleIO client connection pool to manage the Scal…

    …eIO gateway clients, which uses a single gateway client per Powerflex/ScaleIO storage pool and renews it when the session token expires.
    
    - The token is valid for 8 hours from the time it was created, unless there has been no activity for 10 minutes.
      Reference: https://cpsdocs.dellemc.com/bundle/PF_REST_API_RG/page/GUID-92430F19-9F44-42B6-B898-87D5307AE59B.html
    
    Other fixes included:
    
    - Fail the VM deployment when the host specified in the deployVirtualMachine cmd is not in the right state (i.e. either Resource State is not Enabled or Status is not Up)
    
    - Use the physical file size of the template to check the free space availability on the host, while downloading the direct download templates.
    
    - Perform basic tests (for connectivity and file system) on router before updating the health check config data
    	=> Validate the basic tests (connectivity and file system check) on router
    	=> Cleanup the health check results when router is destroyed
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5cce962 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2de8944 View commit details
    Browse the repository at this point in the history
  5. UI Changes to support storage plugin for PowerFlex/ScaleIO storage pool.

    - PowerFlex pool URL generated from the UI inputs(Gateway, Username, Password, Storage Pool) when adding "PowerFlex" Primary Storage
    - Updated protocol to "custom" for PowerFlex provider
    - Allow VM Snapshot for stopped VM on KVM hypervisor and PowerFlex/ScaleIO storage pool
    
    and Minor improvements in PowerFlex/ScaleIO storage plugin code
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3a7c3db View commit details
    Browse the repository at this point in the history
  6. Added support for PowerFlex/ScaleIO volume migration across different…

    … PowerFlex storage instances.
    
    - findStoragePoolsForMigration API returns PowerFlex pool(s) of different instance as suitable pool(s), for volume(s) on PowerFlex storage pool.
    - Volume(s) with snapshots are not allowed to migrate to different PowerFlex instance.
    - Volume(s) of running VM are not allowed to migrate to other PowerFlex storage pools.
    - Volume migration from PowerFlex pool to Non-PowerFlex pool, and vice versa are not supported.
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    71252ea View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    602a708 View commit details
    Browse the repository at this point in the history
  8. Added the PowerFlex/ScaleIO volume/snapshot name to the paths of resp…

    …ective CloudStack resources (Templates, Volumes, Snapshots and VM Snapshots)
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9e92647 View commit details
    Browse the repository at this point in the history
  9. Added new response parameter “supportsStorageSnapshot” (true/false) t…

    …o volume response, and Updated UI to hide the async backup option while taking snapshot for volume(s) with storage snapshot support.
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1c16a1f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ea6f7f1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dc91003 View commit details
    Browse the repository at this point in the history
  12. Fixed the PowerFlex/ScaleIO volume name inconsistency issue in the vo…

    …lume path after migration, due to rename failure
    sureshanaparti committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    010dfee View commit details
    Browse the repository at this point in the history