AVRO-4062: Allow leading underscores for names in idl #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 26, 2024 15:27
The test is not run automatically unless the class naming convention is followed
martin-g
approved these changes
Sep 27, 2024
|
Thanks for the approve @martin-g, is there something more needed to do to get this PR merged? |
opwvhk
approved these changes
Oct 14, 2024
|
Looks good, especially due to the added test case. I also checked the spec on names, en this fixes a bug in allowed names. Thank you! |
martin-g
pushed a commit
that referenced
this pull request
Oct 14, 2024
* AVRO-4062 [java] Fix broken test data * AVRO-4062 [java] Make maven run unit test for IdlReader The test is not run automatically unless the class naming convention is followed * AVRO-4062 Allow leading underscore for names in idl * AVRO-4062 [java] Add test for leading underscore in names --------- Co-authored-by: Isak Lindbeck <[email protected]> (cherry picked from commit ed6d4b7)
I have cherry-picked it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds support for names with leading underscore in idl. Fixing AVRO-4062
The specification is pretty clear that leading underscore is allowed.
Verifying this change
This change added tests and can be verified as follows:
Documentation