Drop missing from juliaeltype if ValidityBitmap is all valid.
#477
+72
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetion
changed the title
juliaeltype if ValidityBitmap is all valid.
|
Fixes #283 |
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
==========================================
- Coverage 87.50% 5.11% -82.39%
==========================================
Files 26 25 -1
Lines 3280 3208 -72
==========================================
- Hits 2870 164 -2706
- Misses 410 3044 +2634
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
reviewed
Aug 4, 2023
| @@ -200,6 +200,7 @@ end | |||
|
|
|||
| Base.size(p::ValidityBitmap) = (p.ℓ,) | |||
| nullcount(x::ValidityBitmap) = x.nc | |||
| Base.all(x::ValidityBitmap) = x.nc == 0 | |||
There was a problem hiding this comment.
I don't love overloading all here; can we just call this allvalid? I don't think we need to overload anything for this.
quinnj
reviewed
Aug 4, 2023
| @@ -540,13 +555,13 @@ function UnionT(f::Meta.Field, convert) | |||
| UT = UnionT{ | |||
| f.type.mode, | |||
| typeids, | |||
| Tuple{(juliaeltype(x, buildmetadata(x), convert) for x in f.children)...}, | |||
| Tuple{(juliaeltype(x, buildmetadata(x), convert, false) for x in f.children)...}, | |||
There was a problem hiding this comment.
Can you help me understand why we hard-code false in a number of places for the allvalid argument? vs. in other places calling all(validity)?
quinnj
reviewed
Aug 4, 2023
|
Ok, I will fix the tests 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384
Fixes #373
This does fail a number of tests, which we can fix after we agree on the direction of this PR.