Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support register custom var prefix #11740

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

louxiu
Copy link
Contributor

@louxiu louxiu commented Nov 12, 2024

Description

In our case, variable is configured by external service and load dynamically to apisix. It would be much better to registering a custom variable prefix instead of statically registering each variable.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 12, 2024
@louxiu louxiu changed the title feat: support register custom var prefix Draft: feat: support register custom var prefix Nov 12, 2024
@louxiu louxiu marked this pull request as draft November 12, 2024 13:44
@louxiu louxiu changed the title Draft: feat: support register custom var prefix feat: support register custom var prefix Nov 12, 2024
@louxiu louxiu force-pushed the register_prefix branch 3 times, most recently from 65e7fd5 to a6b9639 Compare November 13, 2024 09:08
@louxiu louxiu marked this pull request as ready for review November 13, 2024 09:14
@louxiu louxiu marked this pull request as draft November 13, 2024 09:19
@louxiu louxiu marked this pull request as ready for review November 13, 2024 11:20
@louxiu louxiu marked this pull request as draft November 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant