-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fixed broken link to tutorial in Manage API Consumers tutorial #11669
base: master
Are you sure you want to change the base?
docs: Fixed broken link to tutorial in Manage API Consumers tutorial #11669
Conversation
This PR updates the internal link to external to allow the Chinese doc (in which the link is currently broken) to redirect to the English doc; but I'm not sure if this is the best practice. @guoqqqi please help confirm. |
But we already have the corresponding Chinese version, we should modify the documentation of the Chinese version to fix the corresponding broken links. https://apisix.apache.org/zh/docs/apisix/tutorials/expose-api/ |
@guoqqqi Ah thank you! I didn't know that the corresponding tutorial was added in Chinese. I will update the link. |
@guoqqqi Please let me know if b1ec6aa will fix this. I have added a |
Please check the failed CI. |
@kayx23 PR needs approval for the checks to run. I've fixed the issue with the new page not being present in |
Approved. Still has error. |
@kayx23 I missed to add the .md extension in the link. Please check now. |
All checks have passed! |
Description
This PR is a potential fix for the broken link to the tutorial in #11217. The issue is that the link to the tutorial only exists in the English documentation and not in the Chinese version. It was discussed that we could link the Chinese page to the English version of the tutorial as well. I've updated the link so that both versions of the page points to the correct tutorial page instead of
./expose-api.md
, which only exists in the English version and not in Chinese.Fixes #11217
Checklist