Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix unit test issues #3373

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

Tried to fix unit test issues in :https://github.com/apache/amoro/actions/runs/12308627468/job/34358691837

Brief change log

  • Clear derby tables after TestIcebergServerTableDescriptor execution

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the module:ams-server Ams server module label Dec 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.62%. Comparing base (243d289) to head (07bd379).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3373      +/-   ##
============================================
+ Coverage     21.59%   21.62%   +0.03%     
- Complexity     2309     2313       +4     
============================================
  Files           426      426              
  Lines         39719    39724       +5     
  Branches       5624     5623       -1     
============================================
+ Hits           8577     8591      +14     
+ Misses        30414    30406       -8     
+ Partials        728      727       -1     
Flag Coverage Δ
trino 21.62% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong zhoujinsong requested a review from klion26 December 19, 2024 11:03
@zhoujinsong
Copy link
Contributor Author

@klion26 Can you help to check this PR?

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. LGTM

@zhoujinsong zhoujinsong merged commit be8ecf5 into apache:master Dec 20, 2024
4 checks passed
@zhoujinsong zhoujinsong deleted the fix-unit-test-issue branch December 20, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants