Cleanup - Move test helpers to test_utils crate
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
changed the title
test_utils crate
Lichtso
force-pushed
the
cleanup/move_to_test_utils
branch
from
ab0ca33 to
9768a2c
Compare
Lichtso
force-pushed
the
cleanup/move_to_test_utils
branch
from
9768a2c to
76f76d5
Compare
LucasSte
reviewed
Jan 8, 2025
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| //! Virtual machine for SBPF programs. | |||
| #![warn(missing_docs)] | |||
| #![allow(clippy::literal_string_with_formatting_args)] | |||
There was a problem hiding this comment.
Why are we ignoring this case?
There was a problem hiding this comment.
It reports all kinds of false positives (even in comments) and it can't even track the origin correctly, so it will just output random stuff with no way to tell what it was complaining about. There are already multiple bug reports upstream. No idea why they did not just revert it.
LucasSte
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.