-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1: Accounting migrating builtin programs default Compute Unit Limit with feature status (backport of #3975) #4091
base: v2.1
Are you sure you want to change the base?
Conversation
Cherry-pick of 9379fbc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Did first round of conflicts fix. Need to rebase after #3931 is merged to 2.1 |
a643774
to
4321b8f
Compare
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
bit much for a backport innit? |
4321b8f
to
ad676fb
Compare
running on |
… feature status (#3975) * Accounting migrating builtin programs default Compute Unit Limit with its feature gate status * Declare Non/migrating buiiltins in const array, eleminates heap allocation (Vec<>) per transaction * updates for review commients add explicit positional information to migrating builtin feature obj update developer notes, added static_assertion to validate no new items are added, add enum type * use enum to separately define migrating and not-migrating builtins * rename for clarity (cherry picked from commit 9379fbc)
ad676fb
to
f77bd52
Compare
why? stop 😭 Ah, I'm sorry. You are right that #3768 should be bp-ed separately, if it's restrictively needed. I'll fix it. |
Problem
When a builtin program migrated into sbpf, it should no longer be considered as 'builtin', therefore its default Compute Budget Limit should change from 3K to 200K CU, per #3799. It is currently not supported by Compute Budget Instruction processing.
Summary of Changes
3
entries) vectorMigrationBuiltinFeatureCounter
to transaction static meta;try_from()
feature_set
to resolve if builtin has migrated duringcalculate_default_compute_unit_limit()
if Compute Unit Limit was not requested.Fixes #
This is an automatic backport of pull request #3975 done by [Mergify](https://mergify.com).