Apply misc small cleanups to unified scheduler #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Dec 12, 2024
Comment on lines
+287
to
+288
| pub fn working_bank_with_scheduler(&self) -> BankWithScheduler { | ||
| self.banks[&self.highest_slot()].clone_with_scheduler() |
There was a problem hiding this comment.
it turned out returning all call sites ended up calling .clone_with_scheduler() immediately after this. so, just do it inside here.
also, this makes it consistent the cousin (BankForks::working_bank), which isn't returning refs as well.
ryoqun
commented
Dec 12, 2024
| @@ -782,7 +781,7 @@ impl<S: SpawnableScheduler<TH>, TH: TaskHandler> ThreadManager<S, TH> { | |||
| session_result_receiver, | |||
| session_result_with_timings: None, | |||
| scheduler_thread: None, | |||
| handler_threads: Vec::with_capacity(handler_count), | |||
| handler_threads: vec![], | |||
There was a problem hiding this comment.
handler_threads is reassigned in start_threads, so no need to reserve capacity. also, this isn't perf sensitive code.
ryoqun
commented
Dec 12, 2024
| (task, &finished_blocked_task_sender) | ||
| } else { | ||
| continue; | ||
| move || { |
ryoqun
commented
Dec 12, 2024
| @@ -551,7 +551,7 @@ mod chained_channel { | |||
|
|
|||
| pub(super) fn send_chained_channel( | |||
| &mut self, | |||
| context: C, | |||
| context: &C, | |||
There was a problem hiding this comment.
taking ref here will soon be desired in upcoming pr...
There was a problem hiding this comment.
difference here is only that context is not dropped at the end of this function.
ryoqun
commented
Dec 12, 2024
| @@ -1441,7 +1442,7 @@ impl<TH: TaskHandler> InstalledScheduler for PooledScheduler<TH> { | |||
|
|
|||
| impl<S, TH> UninstalledScheduler for PooledSchedulerInner<S, TH> | |||
| where | |||
| S: SpawnableScheduler<TH, Inner = PooledSchedulerInner<S, TH>>, | |||
| S: SpawnableScheduler<TH, Inner = Self>, | |||
ryoqun
added
the
automerge
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
because I have some diff aesthetics, i need some preparation for #3946
Summary of Changes
See individual hunks for explanations
extracted from #3946, see the pr for the general overview.