Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zy/41 exception parsing container #42

Merged
merged 15 commits into from
Jul 18, 2024
Merged

Zy/41 exception parsing container #42

merged 15 commits into from
Jul 18, 2024

Conversation

zheyxu
Copy link
Collaborator

@zheyxu zheyxu commented Jul 12, 2024

for #41

@zheyxu zheyxu linked an issue Jul 12, 2024 that may be closed by this pull request
RDFLIB: Exception when parsing the get response of a container #41
Closed
@zheyxu zheyxu mentioned this pull request Jul 12, 2024
Closed
@zheyxu zheyxu requested review from gjwgit and anushkavidanage July 12, 2024 00:35
anushkavidanage
anushkavidanage reviewed Jul 17, 2024
View reviewed changes
lib/src/turtle/parsettl.dart Outdated
@@ -0,0 +1,116 @@
import '../graph.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as files in the previous PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was removed.

gjwgit
gjwgit approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and check for duplicates. Yes we can do specific comparisons but best if we don't get repeated files across multiple PRs.

@zheyxu zheyxu merged commit a450045 into main Jul 18, 2024
1 check passed
@zheyxu zheyxu deleted the zy/41_exception_parsing_container branch July 18, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkavidanage anushkavidanage anushkavidanage approved these changes

@gjwgit gjwgit gjwgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDFLIB: Exception when parsing the get response of a container
3 participants
@zheyxu @gjwgit @anushkavidanage