Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化 ViewMeta 类型定义和相关文档 #2935

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Oct 23, 2024

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

close #2923

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 23, 2024 8:52am

@github-actions github-actions bot added the pr(feature) new feature label Oct 23, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 23, 2024
Copy link
Contributor

Size Change: 0 B

Total Size: 330 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 229 kB
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.8 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.96 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (ecdc9c8) to head (444f6f2).
Report is 453 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2935      +/-   ##
==========================================
+ Coverage   75.77%   80.83%   +5.06%     
==========================================
  Files         257      180      -77     
  Lines       11994    10426    -1568     
  Branches     2464     2365      -99     
==========================================
- Hits         9088     8428     -660     
+ Misses       1398      554     -844     
+ Partials     1508     1444      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 55b6f55 into next Oct 25, 2024
14 of 15 checks passed
@wjgogogo wjgogogo deleted the docs-view-meta branch October 25, 2024 07:22
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants