Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复分组汇总时,按汇总排序获取排序数据为空 #2370

Merged
merged 11 commits into from
Oct 20, 2023

chore: getMultiData 使用传参格式改回

fa51116
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复分组汇总时,按汇总排序获取排序数据为空 #2370

chore: getMultiData 使用传参格式改回
fa51116
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 19, 2023 in 1s

76.75% (+0.26%) compared to 1adc25d

View this Pull Request on Codecov

76.75% (+0.26%) compared to 1adc25d

Details

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (fa51116) 76.75%.
Report is 74 commits behind head on master.

❗ Current head fa51116 differs from pull request most recent head f61a961. Consider uploading reports for the commit f61a961 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
+ Coverage   76.48%   76.75%   +0.26%     
==========================================
  Files         240      241       +1     
  Lines       12312    12594     +282     
  Branches     2630     2705      +75     
==========================================
+ Hits         9417     9666     +249     
+ Misses       1377     1353      -24     
- Partials     1518     1575      +57     
Files Coverage Δ
packages/s2-core/src/cell/base-cell.ts 82.22% <ø> (-0.23%) ⬇️
packages/s2-core/src/cell/col-cell.ts 89.18% <ø> (-0.02%) ⬇️
packages/s2-core/src/cell/row-cell.ts 75.35% <100.00%> (+2.01%) ⬆️
packages/s2-core/src/cell/table-col-cell.ts 86.53% <ø> (+4.72%) ⬆️
...ackages/s2-core/src/common/constant/interaction.ts 100.00% <ø> (ø)
packages/s2-core/src/common/icons/gui-icon.ts 86.00% <100.00%> (-2.89%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 94.11% <ø> (+0.56%) ⬆️
...s2-core/src/data-set/custom-tree-pivot-data-set.ts 94.11% <100.00%> (+0.17%) ⬆️
packages/s2-core/src/data-set/table-data-set.ts 74.02% <ø> (-0.65%) ⬇️
...-core/src/facet/layout/build-row-tree-hierarchy.ts 80.64% <100.00%> (ø)
... and 46 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.