【WIP】fix: 修复【指标不在最后一级customValueOrder】+ 【分组汇总】+【按汇总值排序】同时使用时，获取排序数据时为空 #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
GaoFuhong,
lcx-seima,
lijinke666,
serializedowen,
stone-lyl and
wjgogogo
NoobNotN
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
reviewed
Oct 13, 2023
|
|
||
| beforeEach(() => { | ||
| sheet = new PivotSheet(getContainer(), dataConfig, s2Options); | ||
| dataSet = new PivotDataSet(sheet); |
There was a problem hiding this comment.
这应该不是 Mock 的 PivotSheet 把, 为什么不直接用 sheet.dataSet, 而要重新赋值
lijinke666
reviewed
Oct 13, 2023
| sortParam, | ||
| }; | ||
| const measureValues = getSortByMeasureValues(params); | ||
| expect(measureValues).toEqual([ |
There was a problem hiding this comment.
Suggested change
| expect(measureValues).toEqual([ | |
| expect(measureValues).toMatchInlineSnapshot() |
NoobNotN
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
🐛 Bugfix
📝 Description
修复修复指标不在最后一级配置与分组汇总同时使用时，获取排序数据元为空。
原因：undefined 值作为汇总标记，不可过滤，需要判断当 key 为 undefined 字符串时手动赋值 undefined
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge