Skip to content

Commit

Permalink
fix: dual-axes thumbnails out of sync
Browse files Browse the repository at this point in the history
  • Loading branch information
anhaohui.ahh committed Oct 15, 2024
1 parent 556b54c commit cffe0a5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: 14

- name: yarn install
run: |
yarn install
Expand Down Expand Up @@ -38,9 +39,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js 14
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 14
architecture: 'x64'
- name: yarn install
run: |
yarn install
Expand Down
2 changes: 1 addition & 1 deletion __tests__/unit/utils/pattern/line-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('utils: line pattern', () => {
drawLine(ctx, cfg as LinePatternCfg, d);
// 传入的是呈现的位置
expect(getPixelColor(canvas, 0, 0).hex).toEqual('#ff0000');
expect(getPixelColor(canvas, 0, height - 1).hex).toEqual('#ff0000');
expect(getPixelColor(canvas, 0, height - 1).hex).toEqual('#000000');
});

it('lineUnitPattern with strokeOpacity', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const version = '2.4.30';
export const version = '2.4.31';

// G2 自定义能力透出
import * as G2 from '@antv/g2';
Expand Down
4 changes: 2 additions & 2 deletions src/plots/dual-axes/util/render-sider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ export const doSliderFilter = (view: View, sliderValue: [number, number]) => {
const values = valuesOfKey(data, xScale.field);
const xValues = isHorizontal ? values : values.reverse();
const xTickCount = size(xValues);
const minIndex = Math.floor(min * (xTickCount - 1));
const maxIndex = Math.floor(max * (xTickCount - 1));
const minIndex = Math.round(min * (xTickCount - 1));
const maxIndex = Math.round(max * (xTickCount - 1));

// 增加 x 轴的过滤器
view.filter(xScale.field, (value: any) => {
Expand Down

0 comments on commit cffe0a5

Please sign in to comment.