Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #1819

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Release #1819

merged 2 commits into from
Nov 5, 2024

Conversation

wang1212
Copy link
Member

@wang1212 wang1212 commented Nov 5, 2024

No description provided.

wang1212 and others added 2 commits November 5, 2024 17:51
…ed (#1817)

* fix: when an element is destroyed, its child elements are not destroyed

* chore: add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

bench.add('get object props', () => {
propsKeys.forEach((key) => {
props[key];

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.

propsKeys.forEach((key) => {
bench.add(`get canvas context props - ${key}`, async () => {
canvasContext[key];

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.

propsKeys.forEach((key) => {
bench.add(`get offscreenCanvas context props - ${key}`, async () => {
offscreenCanvas[key];

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
import * as lil from 'lil-gui';
import { type Canvas } from '@antv/g';
import * as tinybench from 'tinybench';
import { isNil } from '@antv/util';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import isNil.
__tests__/demos/perf/javascript.ts Dismissed Show dismissed Hide dismissed
__tests__/demos/perf/javascript.ts Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants