Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markerStartOffset/markerEndOffset of the path #1808

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

wang1212
Copy link
Member

@wang1212 wang1212 commented Oct 29, 2024

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1790 #1809

💡 Background and solution

Similar to #1760 .

The solution to this issue is the same as #1761 . Fixed rendering anomalies of L/Q/C/A drawing commands for path elements in svg and canvas renderers after configuring markerStartOffset/markerEndOffset attributes

The A command of the canvas renderer has not been fixed yet due to its complexity and frequency of use.

📝 Changelog

Language Changelog
🇺🇸 English fix: the path element's markerStartOffset/markerEndOffset attributes are not drawn correctly
🇨🇳 Chinese fix: path 元素 markerStartOffset/markerEndOffset 属性绘制异常

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@wang1212 wang1212 changed the title fix: markerStartOffset of the path in the svg renderer fix: markerStartOffset/markerEndOffset of the path Oct 29, 2024
@wang1212 wang1212 merged commit 4aa12e8 into release Oct 31, 2024
3 checks passed
@wang1212 wang1212 deleted the fix-1790 branch October 31, 2024 05:41
wang1212 added a commit that referenced this pull request Nov 1, 2024
* fix: `markerStartOffset`/`markerEndOffset` of the path (#1808)

* fix: `markerStartOffset` of the path in the svg renderer is drawn abnormally

* fix: `markerEndOffset` of the path in the svg/canvas renderer is drawn abnormally

* docs: 更新文档

* Version Packages (#1811)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: revert demo style

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant