Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-fire for command-line parsing #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kamilrakoczy
Copy link
Collaborator

Change usage of argparse to python-fire.

Fixes #19

Signed-off-by: Kamil Rakoczy [email protected]

@mgielda
Copy link
Member

mgielda commented Oct 27, 2020

Thanks. It's good to see this implemented in practice. The code did not get shorter :)

Here it seems like argparse is actually a fairly good choice. I added typing info which the latest fire can consume and output in the help. But I ran into one serious issue with fire: namely, it will run the function and only then parse the remaining arguments. That is definitely not something I'd expect as a behavior of a CLI parsing library.

See: google/python-fire#168

To include the typing info in the help output we could use fire's master branch (release 0.3.1 does not yet have this feature) but until the command line argument parsing problem is not solved, I think actually argparse serves us better, so I will hold off merging this (even if I asked for it myself!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to use python-fire for command line parsing
2 participants