add test in secret validation

anthosz · Jul 12, 2017 · 98a984a · 98a984a
1 parent 8c91205
commit 98a984a
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/model/secret_test.go b/model/secret_test.go
@@ -25,10 +25,26 @@ func TestSecret(t *testing.T) {
 			secret := Secret{}
 			g.Assert(secret.Match("pull_request")).IsTrue()
 		})
-		g.It("should pass validation")
+		g.It("should pass validation", func() {
+			secret := Secret{}
+			secret.Name = "secretname"
+			secret.Value = "secretvalue"
+			err := secret.Validate()
+			g.Assert(err).Equal(nil)
+		})
 		g.Describe("should fail validation", func() {
-			g.It("when no image")
-			g.It("when no event")
+			g.It("when no name", func() {
+				secret := Secret{}
+				secret.Value = "secretvalue"
+				err := secret.Validate()
+				g.Assert(err != nil).IsTrue()
+			})
+			g.It("when no value", func() {
+				secret := Secret{}
+				secret.Name = "secretname"
+				err := secret.Validate()
+				g.Assert(err != nil).IsTrue()
+			})
 		})
 	})
 }