Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple assignments to an SSO group #102

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

cmbuckley
Copy link
Member

This change adds support for multiple permissions assignments to a group. The most obvious example for this would be a developer account that has many permissions in lower accounts, but a restricted set in production:

module "sso_example" {
  assignments = {
    "Developer" = [{
      account_ids     = local.non_prod_accounts
      permission_sets = ["AdministratorAccess"]
    }, {
      account_ids     = local.prod_accounts
      permission_sets = ["ReadOnlyAccess"]
    }]
  }
}

With the current implementation the above scenario would require a user to be in 2 groups, which would be unwieldy and error-prone, especially since groups can't be nested in AWS or Entra provisioning.

This module was released a little prematurely - should probably have used a pre-release for the initial cut and get the feedback first. Unfortunately this will be a breaking change.

@cmbuckley cmbuckley merged commit c16fdfe into main Nov 10, 2023
@cmbuckley cmbuckley deleted the sso-assign-multiple branch November 10, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants