Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Partially reverted https://github.com/ansman/validate.js/commit/bebe8… #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huan086
Copy link

@huan086 huan086 commented Nov 7, 2016

…8ed9a40c38a37f44611650b68710e85cee1 to allow "" but reject whitespace, for all validators except equality.

The current behaviour without this commit causes all fields to be required, even without the presence.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7b5a991 on huan086:master into d7f6baa on ansman:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fc331ea on huan086:master into d7f6baa on ansman:master.

@ansman
Copy link
Owner

ansman commented Nov 25, 2016

@huan086 I feel like validate.js should a global setting wether to consider empty string, arrays and objects empty or not.

Ideally presence should capture everything that the other validators lets though. As it is now you can have values that falls through the cracks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 191f9ca on huan086:master into ab5ad5a on ansman:master.

@ansman ansman force-pushed the master branch 4 times, most recently from feffe94 to 40e06a1 Compare June 15, 2019 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants