[WIP]Update close method to cpdef #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
changed the title
webknjaz
reviewed
Aug 4, 2020
Comment on lines
+111
to
+119
| def __del__(self): | ||
| self.close() |
There was a problem hiding this comment.
Why do you think it's better to use __del__ in Python-land?
webknjaz
reviewed
Aug 4, 2020
| @@ -46,7 +46,7 @@ cdef int _process_outputs(libssh.ssh_session session, | |||
| return len | |||
|
|
|||
| cdef class Channel: | |||
| def __cinit__(self, session): | |||
|
@ganeshrn what is it that you're trying to fix here? |
|
@ganeshrn is this still relevant? |
webknjaz
force-pushed
the
close_fix
branch
2 times, most recently
from
169ed04
to
aa1ad0a
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Define ``close()`` as ``cpdef``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Define
close()ascpdefISSUE TYPE
ADDITIONAL INFORMATION