BugFix - awx_collection - lookup_organization failed when teams and resources are not in the same org #15580
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:awx_collection
|
@ecchong are you still working on this? Do you need any help? |
|
@pb82 it is ready for review |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When using "role" module with "lookup_organization", it fails to find the teams it is trying to assign the roles to.
It is because the "lookup_data_populated" is not resetting, so it looks up the teams in the "lookup_organization" for the resources. Mostly it is missing "key == 'teams'" condition.
The integration test didn't catch it because it is not trying to assign role across different organizations.
ISSUE TYPE
COMPONENT NAME
awx_collection/plugins/modules/role.py
AWX VERSION
ADDITIONAL INFORMATION