Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image introspect for PythonPackages #1585

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix image introspect for PythonPackages #1585

merged 1 commit into from
Jul 27, 2023

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Jul 27, 2023 •
edited
Loading

Related: #1582 #1580

This fixes some of the :images related issues with the given EE image:

---
version: 3

images:
  base_image:
    name: quay.io/fedora/python-311:latest

dependencies:
  ansible_core:
    package_pip: ansible-core
  ansible_runner:
    package_pip: ansible-runner
  galaxy:
    collections:
      - community.general
  python:
    - ansible-lint
  • Fixes the list index out of range error, when there is no entry inside PythonPackages.
  • And hence one will be able to browse the other(1-5) entries inside images command like "General Information", "System Packages" etc, even if there is no entry inside "Python Packages".

@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label Jul 27, 2023
@shatakshiiii shatakshiiii merged commit 7868044 into ansible:main Jul 27, 2023
9 checks passed
@shatakshiiii shatakshiiii deleted the fix/python_packages branch July 27, 2023 14:04
@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka audgirka approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shatakshiiii @audgirka @cidrblock