Skip to content

Merge pull request #219 from therealyingtong/therealyingtong-patch-1 #453

Merge pull request #219 from therealyingtong/therealyingtong-patch-1

Merge pull request #219 from therealyingtong/therealyingtong-patch-1 #453

GitHub Actions / Clippy (beta) succeeded Sep 25, 2023 in 0s

Clippy (beta)

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.73.0-beta.7 (7c76587ed 2023-09-22)
  • cargo 1.73.0-beta.7 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (7c76587 2023-09-22)

Annotations

Check warning on line 232 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:232:44
    |
232 |             borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
    |                                            ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 230 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:230:18
    |
230 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`

Check warning on line 232 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:232:44
    |
232 |             borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
    |                                            ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 230 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:230:18
    |
230 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`