Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with resource machine #251

Merged
merged 12 commits into from
Nov 24, 2023
Merged

Sync with resource machine #251

merged 12 commits into from
Nov 24, 2023

Conversation

XuyangSong
Copy link
Collaborator

@XuyangSong XuyangSong commented Nov 21, 2023

According to the Resource Machine Spec, a bunch of parameters and APIs are renamed.

  • Rename note to resource
  • Rename note commitment to resource commitment
  • Rename note encryption to resource encryption
  • Rename note type to resource kind
  • Rename value to quantity
  • Rename value_commitment to delta_commitment, cv_net to delta
  • Rename app_vk to logic
  • Rename app_data_static to label
  • Rename app_data_dynamic to value
  • Rename nonce in resource encryption to encrypt_nonce
  • Rename rho to nonce
  • Rename nullifier key commitment to nullifier public key

Note: is_merkle_checked, rseed, and psi adjusting will be in separated PRs, in which they need more circuit-level modification.

@XuyangSong XuyangSong force-pushed the xuyang/resource_machine_renames branch from fd28a72 to 21da44c Compare November 21, 2023 15:50
@XuyangSong XuyangSong marked this pull request as ready for review November 23, 2023 10:56
@XuyangSong XuyangSong changed the title [WIP]Sync with resource machine Sync with resource machine Nov 23, 2023
@vveiln
Copy link
Member

vveiln commented Nov 23, 2023

If the field previously known as NullifierKeyContainer can still contain both the commitment (nullifier public key) and the nullifier key, we shouldn't rename it

@XuyangSong XuyangSong force-pushed the xuyang/resource_machine_renames branch from 01f2a40 to ad23872 Compare November 23, 2023 14:29
@XuyangSong
Copy link
Collaborator Author

If the field previously known as NullifierKeyContainer can still contain both the commitment (nullifier public key) and the nullifier key, we shouldn't rename it

Reverted the NullifierKeyContainer, and rename the nullifier key commitment to the nullifier public key

@XuyangSong XuyangSong merged commit fd9d365 into main Nov 24, 2023
6 checks passed
@XuyangSong XuyangSong deleted the xuyang/resource_machine_renames branch November 24, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants