Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Merkle tree impl, add serialization for MerklePath, Node, Nullifier #200

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Remove Merkle tree impl, add serialization for MerklePath, Node, Nullifier #200

merged 3 commits into from
Aug 20, 2023

Conversation

bazzilic
Copy link
Contributor

  • Bring a bit more order to the dependencies versions
  • Remove Merkle tree implementation from Taiga codebase
  • Remove Merkle tree test, as there's no more code to test
  • Add from_note constructor to the Merkle tree Node
  • Add Borsh (de)serialization for Node, MerklePath, and Nullifier

@bazzilic bazzilic changed the title Vasily/merkle serialize Remove Merkle tree impl, add serialization for MerklePath, Node, Nullifier Aug 18, 2023
@bazzilic bazzilic merged commit 2775046 into main Aug 20, 2023
7 checks passed
@bazzilic bazzilic deleted the vasily/merkle-serialize branch August 20, 2023 05:31
@mariari mariari mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuyangSong XuyangSong XuyangSong approved these changes

@Acentelles Acentelles Awaiting requested review from Acentelles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bazzilic @XuyangSong