Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fixes issue #1132. Implemented ConstraintLayout #1360

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devanshi7799
Copy link

Description

Implemented ConstraintLayout in gamemap.xml file. Changed FrameLayout to ConstraintLayout
Fixes #1132

Type of Change:

Delete irrelevant options.

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested it on my android phone

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@devanshi7799
Copy link
Author

Please review this and tell me what more changes are to be made

@sammy1997
Copy link
Contributor

@devanshi7799 how is this solving the nesting issue? I think you need to flatten the Layout hierarchy. And it needs to be done for 3 XML files, I can see changes made only to one

@therealsanjeev
Copy link

@sammy1997 sir can i work on this issue?

@sammy1997
Copy link
Contributor

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

@therealsanjeev
Copy link

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

ok sir

@devanshi7799
Copy link
Author

@sammy1997 working on it.
Will update my PR soon :))

@sammy1997
Copy link
Contributor

sammy1997 commented Apr 18, 2020

@devanshi7799 there are 9 commits and many of them are not passing the build. Please squash the commits into 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra-Android: Create constraint layout for gamemap.xml
3 participants