Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Added a anime trailers page #192

Open
wants to merge 4 commits into
base: go
Choose a base branch
from
Open

Added a anime trailers page #192

wants to merge 4 commits into from

Conversation

soulcramer
Copy link
Member

No description provided.

@soulcramer soulcramer changed the title Added a anime trailers page and remove the limitation on displaying only youtube trailers Added a anime trailers page and display trailer from every available source on anime page Sep 30, 2018
@akyoto
Copy link
Member

akyoto commented Oct 10, 2018 •
edited
Loading

I believe the Youtube restriction was in place to discourage non-Youtube sources because we wanted to store them locally as WebM files at some point.

@soulcramer
👌🐛 Revert commit 201e18d and display the latest valid trailer.
03e15de 
After reverting to the previous state of the anime page, I noticed that if the latest trailer is not "valid" (currently which is not coming from Youtube and doesn't have a serviceId) we didn't check if there was a valid one.
To resolve this issue I've added a trailer parameter to the Anime component which should be the latest valid trailer that we have. Otherwise, we don't display the trailer component.
@soulcramer soulcramer changed the title Added a anime trailers page and display trailer from every available source on anime page Added a anime trailers page Nov 28, 2018
@soulcramer soulcramer mentioned this pull request Nov 28, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulcramer @akyoto