Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kept a check for preventing TypeError due to url variable being undefined #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Kept a check for preventing TypeError due to url variable being undefined #4

wants to merge 1 commit into from

Conversation

SukhyAnand
Copy link

Provided fix for issue : angular/angular#25154

@SukhyAnand
Copy link
Author

Reviewers may merge the changes if they look okay.

@gkalpak
Copy link
Member

gkalpak commented Sep 17, 2018

This is the wrong repo. See README.md.
That said, I don't see how this change fixes anything, since url can never be undefined afaict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukhyAnand @gkalpak