Fix Safari compatibility by applying window context to getter function (

#192) The issue was identified using the rule: #%#//scriptlet('set-constant', 'navigator.privateAttribution', 'undefined'). Safari was throwing the error: "TypeError: The Window.navigator getter can only be used on instances of Window," which caused subsequent attempts to access the property to fail. This commit resolves the issue by invoking the previous getter with this explicitly set to window.
anfragment · Jan 6, 2025 · 351e8dc · 351e8dc
1 parent d498c75
commit 351e8dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/scriptlet/bundle.js b/internal/scriptlet/bundle.js
diff --git a/scriptlets/src/set-constant.ts b/scriptlets/src/set-constant.ts
@@ -161,7 +161,9 @@ export function setConstant(
     get: () => {
       let capturedValue;
       if (typeof prevGetter === 'function') {
-        capturedValue = prevGetter();
+        // On certain properties, Safari wants window getters to be called with "window" as "this".
+        // Therefore, we apply instead of doing a regular function call.
+        capturedValue = prevGetter.apply(window);
       } else {
         capturedValue = window[localKey];
       }