Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox open-in-chrome does not work with URLs that contain start word #72

Open
kuntashov opened this issue Nov 10, 2022 · 0 comments
Open

Comments

@kuntashov
Copy link

kuntashov commented Nov 10, 2022

Hi @andy-portmen!
Thank you for such useful and very handy open-in extensions!

I'm faced with minor but annoying bug in open-in-chrome v0.2.8 for firefox:

Given Firefox browser with open-in-chrome ext installed
When i navigate in Firefox to the url "https://en.wiktionary.org/wiki/start"
And I click open-in-chrome button
Then I expect Chrome browser would open
And I expect address bar contains url "https://en.wiktionary.org/wiki/start"
But I see wrong url "https://en.wiktionary.org/wiki/start_/WAIT"

Same happens with https://start.io url (it opens-in-chrome as https://www.start%20/WAIT.io/) and other that contain "start" word in any part of the url.

It seems the bug is here:

.map(s => s.replace('start', isFirefox ? 'start /WAIT' : 'start'));

Chrome extension open-in-firefox works fine with such urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant