Tool calling support. Part I #102
Open
+930
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tool calling support for below providers - OpenAI, Groq, Anthropic, AWS, & Mistral. OpenAI compatible SDKs need to changes for tool calling support. Adding utility ToolManager for users to easily supply tools, and parse model's request for tool usage.
HappyBiningu
approved these changes
Nov 29, 2024
ksolo
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Looks good @rohitprasad15
Nothing blocking, just a few suggestions in the review.
Comment on lines
+43
to
+45
| if isinstance(msg, dict): | ||
| return self._convert_dict_message(msg) | ||
| return self._convert_message_object(msg) |
There was a problem hiding this comment.
It looks like both _convert_dict_message and _convert_message_object logically do the same things. Would it be better to convert to one format and keep one of the convert message methods.
if isinstance(msg, dict):
msg = Message(msg)
return self._convert_message_object(msg)or the other way
if isinstance(msg, Message):
msg = dict(msg)
return self._convert_dict_message(msg)
Comment on lines
+85
to
+103
| tool_input = ( | ||
| tool_call["function"]["arguments"] | ||
| if isinstance(tool_call, dict) | ||
| else tool_call.function.arguments | ||
| ) | ||
| message_content.append( | ||
| { | ||
| "type": "tool_use", | ||
| "id": ( | ||
| tool_call["id"] if isinstance(tool_call, dict) else tool_call.id | ||
| ), | ||
| "name": ( | ||
| tool_call["function"]["name"] | ||
| if isinstance(tool_call, dict) | ||
| else tool_call.function.name | ||
| ), | ||
| "input": json.loads(tool_input), | ||
| } | ||
| ) |
There was a problem hiding this comment.
Similar thought, converting to either an object or dict at the beginning of this would create a consistency that would not require the if/else statements throughout the function call.
aisuite/utils/tool_manager.py
Outdated
There was a problem hiding this comment.
Can you add unit tests for this?
|
@rohitprasad15 When can we expect tool calling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tool calling support for below providers -
OpenAI, Groq, Anthropic, AWS, & Mistral.
OpenAI compatible SDKs need to changes for
tool calling support.
Adding utility ToolManager for users to easily
supply tools, and parse model's request for
tool usage.