Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSOC screen scroll fix #322

Merged

Conversation

deekshithdv
Copy link
Contributor

Problem / Issue No.

Describe Problem / Root Cause

  • Google summer of code code Screen:
    When the list is scrolled up and down, the filters above it does not scroll along with it.
    Also if the filter area is scrolled up it is not possible to scroll it down.

Solution proposed

  • Removed sizedBox for the ListView.builder and added shrinkWrap: true, physics: const NeverScrollableScrollPhysics(),
  • Removed unnecessary void main() in GSOC file

Additional Information

  • There were lint errors in the GSOC file, i have also resolved those

Screenshots

  • Original Screenshot (Problem/Issue)

  • Screen.Recording.2024-10-02.at.10.31.31.mov
  • Updated Screenshot (Fixes/Solution)

  • Screen.Recording.2024-10-03.at.10.19.02.mov

Copy link

github-actions bot commented Oct 3, 2024

Thank you for submitting your pull request! We'll review it as soon as possible.

@deekshithdv
Copy link
Contributor Author

@andoriyaprashant
I have resolved the conflicts, please review the pull request and merge if there are no problems.

@andoriyaprashant andoriyaprashant merged commit c7a2ac4 into andoriyaprashant:main Oct 14, 2024
@andoriyaprashant andoriyaprashant changed the title GSC screen scroll fix GSOC screen scroll fix Oct 14, 2024
@andoriyaprashant
Copy link
Owner

@andoriyaprashant I have resolved the conflicts, please review the pull request and merge if there are no problems.

Done @deekshithdv
Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants