Fixed thousand separator should respect the provided CultureInfo. Closes

#14 Bumped version. Added license in csproj/nupkg.
andersnm · Mar 21, 2019 · ff914bc · ff914bc
1 parent c997e89
commit ff914bc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/ExcelNumberFormat/ExcelNumberFormat.csproj b/src/ExcelNumberFormat/ExcelNumberFormat.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFrameworks>net20;netstandard1.0</TargetFrameworks>
-    <VersionPrefix>1.0.4</VersionPrefix>
+    <VersionPrefix>1.0.5</VersionPrefix>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Description>.NET library to parse ECMA-376 number format strings and format values like Excel and other spreadsheet softwares.</Description>
@@ -13,6 +13,7 @@
     <AssemblyOriginatorKeyFile>ExcelNumberFormat.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
 
 </Project>
diff --git a/src/ExcelNumberFormat/Formatter.cs b/src/ExcelNumberFormat/Formatter.cs
@@ -388,7 +388,7 @@ static void FormatThousandSeparator(string valueString, int digit, CultureInfo c
             var positionInTens = valueString.Length - 1 - digit;
             if (positionInTens > 0 && (positionInTens % 3) == 0)
             {
-                result.Append(",");
+                result.Append(culture.NumberFormat.NumberGroupSeparator);
             }
         }
 

diff --git a/test/ExcelNumberFormat.Tests/Class1.cs b/test/ExcelNumberFormat.Tests/Class1.cs
@@ -430,6 +430,13 @@ public void TestThousandSeparator()
             Assert.AreEqual("0,001,469.07", actual);
         }
 
+        [TestMethod]
+        public void TestThousandSeparatorCulture()
+        {
+            var actual = Format(1469.07, "0,000,000.00", new CultureInfo("da-DK"));
+            Assert.AreEqual("0.001.469,07", actual);
+        }
+
         void TestValid(string format)
         {
             var to = new NumberFormat(format);