local: Fix segfault when destroying block

If both the DMABUF and the MMAP APIs are enabled, and the kernel supports the DMABUF API, local_free_dmabuf() will be called. Therefore, the "pdata" pointer should never be deferenced after that point. Signed-off-by: Paul Cercueil <[email protected]>
analogdevicesinc · Dec 20, 2023 · f4f6053 · f4f6053
1 parent 7407bdf
commit f4f6053
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/local.c b/local.c
@@ -1546,8 +1546,7 @@ static void local_free_block(struct iio_block_pdata *pdata)
 {
 	if (WITH_LOCAL_DMABUF_API && pdata->buf->dmabuf_supported)
 		local_free_dmabuf(pdata);
-
-	if (WITH_LOCAL_MMAP_API && pdata->buf->mmap_supported)
+	else if (WITH_LOCAL_MMAP_API && pdata->buf->mmap_supported)
 		local_free_mmap_block(pdata);
 }