Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adrv9002 interface gain fix #185

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Adrv9002 interface gain fix #185

merged 8 commits into from
Oct 18, 2024

Conversation

SrikanthPagadarai
Copy link
Contributor

No description provided.

'-24dB', '-30dB','-36dB'});
InterfaceGainChannel1Set = matlab.system.StringSet({...
'18dB', '12dB', '6dB', '0dB', '-6dB', '-12dB', '-18dB',...
'-24dB', '-30dB','-36dB'});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the interface gain controls in setupInit as well.

Can you enhance the doc tell the user the interface gain is profile dependent as well

@SrikanthPagadarai SrikanthPagadarai force-pushed the adrv9002_interface_gain_fix branch from 3897320 to 0845b78 Compare October 18, 2024 16:17
@SrikanthPagadarai
Copy link
Contributor Author

Need to update the interface gain controls in setupInit as well.

Can you enhance the doc tell the user the interface gain is profile dependent as well

Updated setupInit and doc-strings.

@tfcollins tfcollins merged commit d2af7da into master Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants