Support channel options like highwatermark #778
Conversation
| if (arguments.length === 1) { | ||
| cb = options; | ||
| options = undefined; | ||
| } |
There was a problem hiding this comment.
Maintain backwards compatibility if no options are specified
| var ch = new Channel(this.connection); | ||
| ch.setOptions(options); |
There was a problem hiding this comment.
I used a setter to specify the channel options to avoid making a breaking change to the Channel constructor
| if (arguments.length === 1) { | ||
| cb = options; | ||
| options = undefined; | ||
| } |
There was a problem hiding this comment.
Maintain backwards compatibility if no options are specified
| var ch = new ConfirmChannel(this.connection); | ||
| ch.setOptions(options); |
There was a problem hiding this comment.
I used a setter to specify the channel options to avoid making a breaking change to the Channel constructor
| channelOptions.highWaterMark = baseline * 2; | ||
| done(); | ||
| }) | ||
| }); |
There was a problem hiding this comment.
This "test" finds how much the local environment running the test can take before the buffer is saturated, then updates the channel options for the next test. It's more than a little hacky, but I couldn't think of a better way to get the test working reliably.
Allows setting channel options like highwatermark. See #264