-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic test upload #6
Draft
TomWoodward
wants to merge
4
commits into
amp-up-io:main
Choose a base branch
from
TomWoodward:qti-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pleased and excited that you've attempted to add some Import
capabilities.
Content Package import is an extremely advanced capability. There are
mountains of code associated with CP Import and Item + Test Validation in
the Amp-up.io Content Bank.
Thank you for this PR and also for your suggestion about using a Github
Discussion. I have done as you've suggested and enabled a Discussion
<https://github.com/amp-up-io/qti3-item-player-controller/discussions>
because this is an important topic. Can I interest you in moving this
topic over here?
…On Fri, May 17, 2024 at 10:15 AM Thomas Woodward ***@***.***> wrote:
I was trying to get more familiar with the runner and test it with
different qti content. i'm not sure if this is something you're interested
in merging, if you are i will clean up the gross parts.
the singleton pattern is not strictly necessary because the underlying
array is shared anyway, but because i was expecting the changes to be
shared it seemed like a good idea at the time.
the assessment level import is super naive, but it didn't seem like the
project supported the "Test" level features anyway so i left it at putting
all the items in a list without any of the other stuff.
i've never worked with vue before and i'm new to qti, i would like to
learn more. some of the example content i tried to use did not work so
great, but i'm not sure how intended that is based on the limitations of
the examples and project support. if you wanted to enable discussions on
this repo, or had some other venue for questions, i would love to talk more
about it.
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- e101495
<e101495>
this is becoming more complicated than i thought
- 0fa1198
<0fa1198>
grossly making progress
- 0402557
<0402557>
refine import a little
- 4de1302
<4de1302>
Revert whitespace
File Changes
(4 files
<https://github.com/amp-up-io/qti3-item-player-controller/pull/6/files>)
- *M* src/helpers/ItemFactory.js
<https://github.com/amp-up-io/qti3-item-player-controller/pull/6/files#diff-a1904398cc246bddce4a6e3c32defe36cd5108640d7a81d8594bd701e3750d47>
(15)
- *M* src/helpers/TestControllerUtilities.js
<https://github.com/amp-up-io/qti3-item-player-controller/pull/6/files#diff-cb230ffbecdd4d2dd48aba9e540ddc16267f7687730ae719460011c0e24a4e37>
(4)
- *M* src/helpers/TestFactory.js
<https://github.com/amp-up-io/qti3-item-player-controller/pull/6/files#diff-b5a8377512a0bc32b3d2f861b85cfdc7c467a7b3d9440af16ab629dd12707810>
(29)
- *M* src/views/Home.vue
<https://github.com/amp-up-io/qti3-item-player-controller/pull/6/files#diff-2dc54a20fa4ab6845b4b0f252336e107d33a13f5c05d966e5c104770a1b292fd>
(109)
Patch Links:
- https://github.com/amp-up-io/qti3-item-player-controller/pull/6.patch
- https://github.com/amp-up-io/qti3-item-player-controller/pull/6.diff
—
Reply to this email directly, view it on GitHub
<#6>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3MLI7NRHWOYQFVTF5PEDZCY3KXAVCNFSM6AAAAABH4P6JJWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDGMRTHA4DIOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get more familiar with the runner and test it with different qti content. i'm not sure if this is something you're interested in merging, if you are i will clean up the gross parts.
the singleton pattern is not strictly necessary because the underlying array is shared anyway, but because i was expecting the changes to be shared it seemed like a good idea at the time.
the assessment level import is super naive, but it didn't seem like the project supported the "Test" level features anyway so i left it at putting all the items in a list without any of the other stuff.
i've never worked with vue before and i'm new to qti, i would like to learn more. some of the example content i tried to use did not work so great, but i'm not sure how intended that is based on the limitations of the examples and project support. if you wanted to enable discussions on this repo, or had some other venue for questions, i would love to talk more about it.