-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Open Trickler w/ Python #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed some pylint issues.
…e cases. Verified some TODOs are fixed.
…, update server.sh launcher.
…ch on memcache calls. Add timer delay in loop.
…c_update, conflicts with exisiting function from parent class.
…config.txt on the BOOT partition.
…cs/projects into feature/python-trickler-rewrite
erichiggins
commented
Aug 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SD images seem to work as expected. Merging for now to prioritize one language and major version over two. Any other bugs can be fixed as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goals of this PR are to improve stability, maintainability, and code readability.
Here a few, more detailed, reasons:
Other functional changes in this PR:
Issues: Improve trickler performance (speed, accuracy) #15
Issues: PWM control for Vibro Motor #33
Issues: Web interface for Trickler #20
trickler/scales.py
) was written to support multiple scale models, including command-line testingIssues: Use other RS232 scales i.e. Acculab #35 Connect to mettler toledo #39
Issues: Mobile app does not update target weight when BT connection is re-established #18
Issues: Add powder-drop support #21
Open issues:
0
values where they can be confused withnull
values)opentrickler_api.yaml
)