Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space in help in between -a and [DEVICE] #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pvalena
Copy link

@pvalena pvalena commented Jan 11, 2021

As it has otherwise no effect. I made a note in README as well.


Not sure this is correct approach, but also I don't know how to fix this other way in https://github.com/ammen99/wf-recorder/blob/master/src/main.cpp#L693, nor how to report an the unknown arg - this may be a bug.

I didn't edit this in man pages as well, as I'm unsure what's the proper way.

Note that there's a secondary issue- no error is thrown when the device is specified (and ignored), separated by a space (iow as another arg).

Thanks for a great program!

@ammen99
Copy link
Owner

ammen99 commented Jan 11, 2021

Looks good! However, I suspect the man page will also need similar treatment.

@@ -542,7 +542,7 @@ Use Ctrl+C to stop.)");
#ifdef HAVE_PULSE
printf(R"(

-a, --audio [DEVICE] Starts recording the screen with audio.
-a, --audio[DEVICE] Starts recording the screen with audio.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, actually, I think there should be a space for the long option, shouldn't it?

Copy link
Author

@pvalena pvalena Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work at all:

$ wf-recorder --audioalsa_output.pci-0000_00_1f.3.analog-stereo.monitor -f verunka-test.mkv
wf-recorder: unrecognized option '--audioalsa_output.pci-0000_00_1f.3.analog-stereo.monitor'
Unsupported command line argument (null)
Please select an output from the list to capture (enter output no.):
1. Name: eDP-1 Description: Chimei Innolux Corporation 0x14C9 0x00000000 (eDP-1)
2. Name: HDMI-A-2 Description: Philips Consumer Electronics Company PHL 325E1 0x00003888 (HDMI-A-2)
Enter output no.:^C

$ wf-recorder --audio alsa_output.pci-0000_00_1f.3.analog-stereo.monitor -f verunka-test.mkv
Please select an output from the list to capture (enter output no.):
1. Name: eDP-1 Description: Chimei Innolux Corporation 0x14C9 0x00000000 (eDP-1)
2. Name: HDMI-A-2 Description: Philips Consumer Electronics Company PHL 325E1 0x00003888 (HDMI-A-2)
Enter output no.:2
selected region 0 0 0 0
Setting codec option: crf=20
Setting codec option: preset=ultrafast
Setting codec option: tune=zerolatency
Choosing pixel format yuv420p
[libx264 @ 0x7f9d98002700] using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2
[libx264 @ 0x7f9d98002700] profile Constrained Baseline, level 5.1, 4:2:0, 8-bit
[libx264 @ 0x7f9d98002700] 264 - core 161 r3020 d198931 - H.264/MPEG-4 AVC codec - Copyleft 2003-2020 - http://www.videolan.org/x264.html - options: cabac=0 ref=1 deblock=0:0:0 analyse=0:0 me=dia subme=0 psy=1 psy_rd=1.00:0.00 mixed_ref=0 me_range=16 chroma_me=1 trellis=0 8x8dct=0 cqm=0 deadzone=21,11 fast_pskip=1 chroma_qp_offset=0 threads=8 lookahead_threads=8 sliced_threads=1 slices=8 nr=0 decimate=1 interlaced=0 bluray_compat=0 constrained_intra=0 bframes=0 weightp=0 keyint=250 keyint_min=25 scenecut=0 intra_refresh=0 rc=crf mbtree=0 crf=20.0 qcomp=0.60 qpmin=0 qpmax=69 qpstep=4 ip_ratio=1.40 aq=0
Output #0, matroska, to 'verunka-test.mkv':
    Stream #0:0: Unknown: none (libx264)
    Stream #0:1: Unknown: none (aac)
[matroska @ 0x7f9d98000d40] Using AVStream.codec to pass codec parameters to muxers is deprecated, use AVStream.codecpar instead.
[matroska @ 0x7f9d98000d40] Using AVStream.codec to pass codec parameters to muxers is deprecated, use AVStream.codecpar instead.
Using PulseAudio device: default

Sorry I didn't try it.

@pvalena
Copy link
Author

pvalena commented Jan 11, 2021

Feel free to cherry pick / amend my PR as you choose. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants