Skip to content

Commit

Permalink
fix: do not pass args to msvc choco
Browse files Browse the repository at this point in the history
  • Loading branch information
aminya committed Dec 5, 2021
1 parent a381fc0 commit b3725a6
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions src/msvc/msvc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,11 @@ export async function setupMSVC(
}
} else if (version === "2017") {
toolset = "14.16"
await setupChocoPack("visualstudio2017buildtools", "15.9.41.0", [
"--package-parameters",
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
])
await setupChocoPack("visualstudio2017buildtools", "15.9.41.0", [])
// VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.16" // TODO verify path
} else if (version === "2019") {
toolset = "14.29"
await setupChocoPack("visualstudio2019buildtools", "16.11.7.0", [
"--package-parameters",
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
])
await setupChocoPack("visualstudio2019buildtools", "16.11.7.0", [])
// VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133"
}
} catch (e) {
Expand Down

0 comments on commit b3725a6

Please sign in to comment.