Fix implied policy in service account #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the following minio release: https://github.com/minio/minio/releases/tag/RELEASE.2024-10-02T17-50-41Z empty policies are returned differently for service accounts. See also: minio/minio#18346
This results in terraform trying to delete policies which where not set in the service account resource.
This pr ignores implied policies for service accounts. Also updates minio versions in docker compose to latest release.
TestServiceAccount_Policy failed on the new version, after fixing it works on the older minio version and new version, making it backwards compatible.
Reference
Closing issues