New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove now-unnecessary Makevars with Rcpp::LdFlags #647

Merged

stefvanbuuren merged 1 commit into amices:master from brookslogan:remove-deprecated-ldflags

Jul 29, 2024

Contributor

brookslogan commented Jun 12, 2024

Rcpp:::LdFlags() is deprecated and produces an empty string, and hasn't been needed for long enough that there may not be loss in compatibility with current
systems. Removing these Makevars settings is a simple way to address issues for some system x Rprofile combinations that I encountered (#646).

Benefits:

Brings package up to date with respect to this deprecation.
Closes Installation fails when Rprofile prints to stdout #646 (though a bit of an edge case).
(Potentially?:) If a user already is providing a PKG_LIBS setting via system Makevars / environment variables, that setting will no longer be overwritten, which is presumably desirable.

Risks and drawbacks:

I haven't tested this outside my Fedora system. In particular, I haven't tested on Windows. But the Rcpp documentation does not list Windows or any other OS as an exception to this deprecation.
If people are running more-than-decade-old Rcpp versions, this may break compilation for them.


          Remove now-unnecessary Makevars with Rcpp::LdFlags

d8a558a

Rcpp:::LdFlags() is deprecated and produces an empty
string (https://www.rdocumentation.org/packages/Rcpp/versions/1.0.12/topics/LdFlags-deprecated),
and hasn't been needed for long enough that there may not be loss in
compatibility with current
systems (RcppCore/Rcpp#1302 (comment)).
Removing these Makevars settings is a simple way to address issues for some
system x Rprofile combinations (amices#646).

brookslogan mentioned this pull request

Installation fails when Rprofile prints to stdout #646

Closed

Member

stefvanbuuren commented Jul 29, 2024

I found that Makevars and Makevars.win are optional since 2017, so I assume it is safe to remove both files.

stefvanbuuren merged commit 5f9fbc1 into amices:master

5 of 6 checks passed

brookslogan deleted the remove-deprecated-ldflags branch

July 31, 2024 22:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet